Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HB-6544][HB-6712][HB-6713] Updating Hardcoded Values into Constants, Adaptive Banner Architectural Fixes, Modular Editor Windows #199

Merged

Conversation

SCastanedaMunoz
Copy link
Collaborator

@SCastanedaMunoz SCastanedaMunoz commented Oct 30, 2023

Title

HB-6544 Updating Hardcoded Values into Constants
HB-6712 Modularize Editor Window Support
HB-6713 Separate Adapters Window Versioning from UPM Package

Description

  • The Unity SDK has some hard coded constants in places that might be nice to pull out into const strings.
  • Currently Editor Configuration Windows such as Adapter Windows & Settings are tied to each other, for proper NuGet distribution, we need to be able to disable/enable windows as needed.
  • Currently the Adapter Windows require to know the version of the UPM package in order to provide Chartboost Mediation dependencies. This is a bad approach since it limits our distribution to only UPM.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)
  • Refactor / Maintenance (refactoring code to be cleaner/easier to maintain)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 1962646. ± Comparison against base commit e80d8b3.

♻️ This comment has been updated with latest results.

@SCastanedaMunoz SCastanedaMunoz changed the title Updating Hardcoded Constants, Adaptive Banner Fixes, Modular Editor Windows [HB-6544][HB-6712][HB-6713] Updating Hardcoded Values into Constants, Adaptive Banner Architectural Fixes, Modular Editor Windows Nov 1, 2023
@SCastanedaMunoz SCastanedaMunoz requested review from a team, bwised, kushG and cb-jpadilla and removed request for a team November 1, 2023 19:09
@SCastanedaMunoz SCastanedaMunoz self-assigned this Nov 1, 2023
@SCastanedaMunoz SCastanedaMunoz added enhancement New feature or request bugfix Something has been fixed api refactoring API refactoring features or changes labels Nov 1, 2023
@SCastanedaMunoz SCastanedaMunoz added this to the 4.7.0 milestone Nov 1, 2023
@SCastanedaMunoz SCastanedaMunoz marked this pull request as ready for review November 1, 2023 19:09
Copy link
Contributor

@kushG kushG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SCastanedaMunoz SCastanedaMunoz merged commit 7976073 into develop Nov 1, 2023
@SCastanedaMunoz SCastanedaMunoz deleted the HB-6544-zynga-audit-refactor-hard-coded-constants branch November 1, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api refactoring API refactoring features or changes bugfix Something has been fixed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants