Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dot/sync): Implement state sync strategy #4425

Open
wants to merge 21 commits into
base: diego/warpsync/strategy
Choose a base branch
from
Open

feat(dot/sync): Implement state sync strategy #4425

wants to merge 21 commits into from

Conversation

dimartiro
Copy link
Contributor

@dimartiro dimartiro commented Dec 19, 2024 •
edited
Loading

Changes

Implements state sync strategy as the next step to be able to use the warp sync process.
This change includes:

  • State sync strategy implementation
  • Refactor StateRequestProvider
    • Move it as part of sync package
    • Use it in state retrieval script and state sync strategy
    • Tests
  • Strategy switching
  • Refactor sync service to create the strategies within it as we discussed here
    • Fix tests
  • Improve logs
    • Remove some redundant logs
    • Modify some log levels to clean up the "production" logs
  • Tests

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

Closes: #4238

@dimartiro dimartiro linked an issue Dec 19, 2024 that may be closed by this pull request
Implement state sync strategy #4238
Open
@dimartiro dimartiro force-pushed the diego/warpsync/strategy branch from a1b63c3 to 36b57e0 Compare December 19, 2024 16:37
@dimartiro dimartiro force-pushed the diego/statesync/strategy branch from 61d4a98 to 956d49d Compare December 19, 2024 16:47
@dimartiro dimartiro force-pushed the diego/warpsync/strategy branch from 36b57e0 to 5ce032d Compare January 7, 2025 17:32
@dimartiro dimartiro force-pushed the diego/statesync/strategy branch 2 times, most recently from f0aba98 to d6443a2 Compare January 8, 2025 15:43
@dimartiro dimartiro self-assigned this Jan 8, 2025
@dimartiro dimartiro marked this pull request as ready for review January 9, 2025 13:44
@dimartiro dimartiro added A-blocked issue or PR is blocked until something else changes. S-sync-polkadot related to particular network syncing. S-sync-kusama related to particular network syncing. C-complex Complex changes across multiple modules. Possibly will require additional research. S-sync-paseo related to particular network syncing. S-sync-westend related to particular network syncing. T-implementation this issue/pr is a new feature or functionality. labels Jan 13, 2025
@dimartiro dimartiro force-pushed the diego/warpsync/strategy branch 2 times, most recently from adfaa59 to eea6c27 Compare January 16, 2025 15:13
@dimartiro dimartiro force-pushed the diego/statesync/strategy branch from 661797c to 66e5284 Compare January 16, 2025 15:15
haikoschol
haikoschol reviewed Jan 17, 2025
View reviewed changes
dot/network/messages/state.go Show resolved Hide resolved
dot/sync/service.go Show resolved Hide resolved
dot/sync/service.go Outdated Show resolved Hide resolved
dot/sync/state_request_provider.go Outdated Show resolved Hide resolved
dot/sync/state_request_provider.go Outdated Show resolved Hide resolved
dot/sync/state_request_provider_test.go Outdated Show resolved Hide resolved
@dimartiro dimartiro force-pushed the diego/warpsync/strategy branch from eea6c27 to 5337adf Compare January 20, 2025 13:07
@dimartiro dimartiro force-pushed the diego/statesync/strategy branch from 8c9d871 to 3995c15 Compare January 20, 2025 13:24
@dimartiro dimartiro removed the A-blocked issue or PR is blocked until something else changes. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haikoschol haikoschol haikoschol approved these changes

@EclesioMeloJunior EclesioMeloJunior Awaiting requested review from EclesioMeloJunior EclesioMeloJunior is a code owner

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@P1sar P1sar Awaiting requested review from P1sar P1sar is a code owner

Assignees

@dimartiro dimartiro

Labels
C-complex Complex changes across multiple modules. Possibly will require additional research. S-sync-kusama related to particular network syncing. S-sync-paseo related to particular network syncing. S-sync-polkadot related to particular network syncing. S-sync-westend related to particular network syncing. T-implementation this issue/pr is a new feature or functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement state sync strategy
2 participants
@dimartiro @haikoschol