Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prospective-parachains): Implement HandleIntroduceSecondedCandidate #4350

Merged
merged 76 commits into from
Jan 16, 2025
Merged

feat(prospective-parachains): Implement HandleIntroduceSecondedCandidate #4350

merged 76 commits into from
Jan 16, 2025

Conversation

rebonat0
Copy link

@rebonat0 rebonat0 commented Nov 28, 2024 •
edited by EclesioMeloJunior
Loading

Changes

This PR introduces the HandleIntroduceSecondedCandidate func to prospectiveparachains package.

Notes:
currently there's no implementation for ImplicitView, reference is:
polkadot-sdk reference

Tests

go test -timeout 30s github.com/ChainSafe/gossamer/dot/parachain/prospective-parachains

Issues

closes #4308

EclesioMeloJunior and others added 20 commits November 11, 2024 20:57
@EclesioMeloJunior
feat: starting the fragment chain implementation
afa3e68 
- Added: Candidate Entry
- (inclusion_emulator): Added ProspectiveCandidate, Modification error and Fragment Validity error
@EclesioMeloJunior
feat: implemented CandidateStorage
404f5fe
@EclesioMeloJunior
feat: create Scope, working on inclusionemulator.Fragment
6648464
@EclesioMeloJunior
wip: implementing validateAgainstConstraints
5119649
@EclesioMeloJunior
feat: implement BackedChain
e072160
@EclesioMeloJunior
wip: FragmentChain struct implementation
0de059a
@EclesioMeloJunior
feat: full FragmentChain implementation done
0388b02
@EclesioMeloJunior
chore: wip fragment chain tests
1b796b8
@EclesioMeloJunior
chore: TestPopulateAndCheckPotential done
f11ee4f
@EclesioMeloJunior
feat: bring polkadot-sdk test coverage to fragment chain
6a001c8
@EclesioMeloJunior
chore: remove dsstore
6b30bc6
@EclesioMeloJunior
chore: change loopt
5f01ccb
@EclesioMeloJunior
Merge branch 'feat/parachain' into eclesio/fragment-chain-impl
987c880
@rebonat0
feature: implement HandleIntroduceSecondedCandidate
e9b4852
@rebonat0
progress: started tests
15feb1b
@rebonat0
added test case example
fe27ee3
@rebonat0
implement HandleIntroduceSecondedCandidate on processMessage
a8960d8
@rebonat0
added tests
a53f150
@rebonat0
added new view instance on NewProspectiveParachains
038dfce
@rebonat0
added more test scenarios
0465a41
@CLAassistant
Copy link

CLAassistant commented Nov 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@EclesioMeloJunior EclesioMeloJunior changed the title Feature: Implement HandleIntroduceSecondedCandidate on prospectiveparachains package feat(prospective-parachains): Implement HandleIntroduceSecondedCandidate Nov 28, 2024
@EclesioMeloJunior
Copy link
Member

should wait the merge of branch of #4337

@EclesioMeloJunior EclesioMeloJunior deleted the branch ChainSafe:feat/parachain January 6, 2025 20:51
@EclesioMeloJunior
Copy link
Member

@rebonat0 this PR is unblocked now, sorry for the long delay!

@EclesioMeloJunior EclesioMeloJunior changed the base branch from eclesio/fragment-chain-impl to feat/parachain January 7, 2025 13:23
@haikoschol
Copy link
Contributor

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@rebonat0 please sign the CLA

haikoschol
haikoschol requested changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@haikoschol haikoschol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small issues and two formatting nits.

dot/parachain/prospective-parachains/prospective-parachains.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/prospective-parachains.go Show resolved Hide resolved
dot/parachain/prospective-parachains/prospective-parachains.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/prospective-parachains.go Outdated Show resolved Hide resolved
haikoschol
haikoschol approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@haikoschol haikoschol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@haikoschol haikoschol enabled auto-merge (squash) January 16, 2025 16:18
@haikoschol haikoschol merged commit e0be44f into ChainSafe:feat/parachain Jan 16, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@haikoschol haikoschol haikoschol approved these changes

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya

@P1sar P1sar Awaiting requested review from P1sar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rebonat0 @CLAassistant @EclesioMeloJunior @haikoschol