fix(dot/state): fix a bug in IsDescendantOf

dot/state/block.go

@@ -773,10 +773,14 @@ func (bs *BlockState) IsDescendantOf(ancestor, descendant common.Hash) (bool, er
 			return false, fmt.Errorf("getting header: %w", err2)
 		}
 
-		for current := descendantHeader; descendantHeader.Number < ancestorHeader.Number; {
+		for current := descendantHeader; current.Number > ancestorHeader.Number; {
 			if current.ParentHash == ancestor {
 				return true, nil
 			}
+			current, err2 = bs.GetHeader(current.ParentHash)
+			if err2 != nil {
+				return false, fmt.Errorf("getting header: %w", err2)
+			}
 		}
 
 		return false, nil

dot/state/epoch.go

@@ -12,7 +12,6 @@ import (
 
 	"github.com/ChainSafe/chaindb"
 	"github.com/ChainSafe/gossamer/dot/types"
-	"github.com/ChainSafe/gossamer/lib/blocktree"
 	"github.com/ChainSafe/gossamer/lib/common"
 	"github.com/ChainSafe/gossamer/pkg/scale"
 )
@@ -399,7 +398,7 @@ func (nem nextEpochMap[T]) Retrieve(blockState *BlockState, epoch uint64, header
 		// sometimes while moving to the next epoch is possible the header
 		// is not fully imported by the blocktree, in this case we will use
 		// its parent header which migth be already imported.
-		if errors.Is(err, blocktree.ErrEndNodeNotFound) {
+		if errors.Is(err, chaindb.ErrKeyNotFound) {
 			parentHeader, err := blockState.GetHeader(header.ParentHash)
 			if err != nil {
 				return nil, fmt.Errorf("cannot get parent header: %w", err)

dot/sync/chain_processor.go

@@ -92,8 +92,8 @@ func (s *chainProcessor) processReadyBlocks() {
 
 		if err := s.processBlockData(*bd); err != nil {
 			// depending on the error, we might want to save this block for later
-			if !errors.Is(err, errFailedToGetParent) {
-				logger.Errorf("block data processing for block with hash %s failed: %s", bd.Hash, err)
+			if !errors.Is(err, errFailedToGetParent) && !errors.Is(err, blocktree.ErrParentNotFound) {
+				logger.Tracef("block data processing for block with hash %s failed: %s", bd.Hash, err)
 				continue
 			}
 

lib/blocktree/errors.go

@@ -20,6 +20,7 @@ var (
 	// ErrEndNodeNotFound is returned if the end of a subchain does not exist
 	ErrEndNodeNotFound = errors.New("end node does not exist")
 
+	ErrKeyNotFound = errors.New("key not found")
 	// ErrNilDescendant is returned if calling subchain with a nil node
 	ErrNilDescendant = errors.New("descendant node is nil")
 

lib/blocktree/leaves.go

@@ -5,7 +5,7 @@ package blocktree
 
 import (
 	"bytes"
-	"errors"
+	"fmt"
 	"sync"
 
 	"github.com/ChainSafe/gossamer/lib/common"
@@ -41,7 +41,7 @@ func (lm *leafMap) store(key Hash, value *node) {
 func (lm *leafMap) load(key Hash) (*node, error) {
 	v, ok := lm.smap.Load(key)
 	if !ok {
-		return nil, errors.New("key not found")
+		return nil, fmt.Errorf("%w: %s", ErrKeyNotFound, key)
 	}
 
 	return v.(*node), nil