Skip to content

Commit

Permalink
Fix SSL issue with Jarvis
Browse files Browse the repository at this point in the history
  • Loading branch information
@Cat5TV
Cat5TV authored Jan 8, 2018
1 parent 294cbc4 commit 9df2421
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion default.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
cat5Live = {}

# declares the variable cat5ShowURL for show url list
cat5ShowURL = "https://rss.cat5.tv/kodi/shows.php"
cat5ShowURL = "http://rss.cat5.tv/kodi/shows.php"

# sets a value to the addon_handle for kodi
xbmcplugin.setContent(addon_handle, 'movies')
Expand Down

3 comments on commit 9df2421

@zatricky
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not how you fix SSL ... :-/

@solbu
Copy link
Contributor

@solbu solbu commented on 9df2421 May 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, yes it is.
Kodi 16.1 have issues with SSL/TLS, which our plugin can't fix. Not in a way that we can figure out
And since there is no secrets exchanged, we decided to downgrade to unencrypted transports, rather than forcing our users upgrade to kodi 17.

The issue is here

I've done a little digging as I remember it is only kodi 16 that have this issue, and the SSL feature broke in kodi 16.1. it seems to be a problem in pyOpenssl. Upstream Issue here: pyca/pyopenssl#542

@Cat5TV
Copy link
Owner Author

@Cat5TV Cat5TV commented on 9df2421 May 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@solbu is correct, and perhaps just the commit message is misleading - we didn't "fix SSL" - we made the channel work across all versions of Kodi by disabling SSL (which it has trouble with). It is obtaining video and RSS content only - there is no information sent to the server and therefore absolutely no reason to require SSL in this case. We'd rather it be using https just because that's how our infrastructure is setup, but if Kodi doesn't work with it, our hands are tied and at least this fixes the issue people were having.

Please sign in to comment.