A0-1763: Remove v0 connections from clique (#895)

* v0 removal

* Remove ConnectionType

* Update some comments

finality-aleph/src/network/clique/manager/mod.rs

@@ -8,10 +8,7 @@ use futures::channel::mpsc;
 use crate::network::{clique::PublicKey, Data, PeerId};
 
 mod direction;
-mod legacy;
-
 use direction::DirectedPeers;
-pub use legacy::Manager as LegacyManager;
 
 /// Error during sending data through the Manager
 #[derive(Debug, PartialEq, Eq)]

finality-aleph/src/network/clique/outgoing.rs

@@ -5,9 +5,7 @@ use log::{debug, info};
 use tokio::time::{sleep, timeout, Duration};
 
 use crate::network::clique::{
-    protocols::{
-        protocol, ConnectionType, ProtocolError, ProtocolNegotiationError, ResultForService,
-    },
+    protocols::{protocol, ProtocolError, ProtocolNegotiationError, ResultForService},
     ConnectionInfo, Data, Dialer, PeerAddressInfo, PublicKey, SecretKey, LOG_TARGET,
 };
 
@@ -110,7 +108,7 @@ pub async fn outgoing<SK: SecretKey, D: Data, A: Data + Debug, ND: Dialer<A>>(
         // we send the "new" connection type, because we always assume it's new until proven
         // otherwise, and here we did not even get the chance to attempt negotiating a protocol
         if result_for_parent
-            .unbounded_send((public_key, None, ConnectionType::New))
+            .unbounded_send((public_key, None))
             .is_err()
         {
             debug!(target: LOG_TARGET, "Could not send the closing message, we've probably been terminated by the parent service.");