units in external api: more review changes, removed NodeIndex from Or…

…deredUnit::parents
Cardinal-Cryptography · Apr 29, 2024 · f52f918 · f52f918
1 parent 1effa2c
commit f52f918
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/consensus/src/dag/reconstruction/mod.rs b/consensus/src/dag/reconstruction/mod.rs
@@ -81,11 +81,7 @@ impl<D: Data, H: Hasher, K: MultiKeychain> From<ReconstructedUnit<Signed<FullUni
     for OrderedUnit<D, H>
 {
     fn from(unit: ReconstructedUnit<Signed<FullUnit<H, D>, K>>) -> Self {
-        let parents = unit
-            .parents()
-            .into_iter()
-            .map(|(ix, hash)| (ix, *hash))
-            .collect();
+        let parents = unit.parents().into_iter().map(|(_, hash)| *hash).collect();
         let unit = unit.unpack();
         let creator = unit.creator();
         let round = unit.round();

diff --git a/consensus/src/member.rs b/consensus/src/member.rs
@@ -130,7 +130,7 @@ impl<DP: DataProvider, FH: FinalizationHandler<DP::Output>, US: AsyncWrite, UL:
         }
     }
 
-    pub fn new_using_unit_finalization_handler<
+    pub fn new_with_unit_finalization_handler<
         H: Hasher,
         UFH: FinalizationHandler<BatchOfUnits<DP::Output, H>>,
     >(

diff --git a/types/src/dataio.rs b/types/src/dataio.rs
@@ -36,7 +36,7 @@ pub trait FinalizationHandler<D>: Sync + Send + 'static {
 /// which can be then used for example for the purpose of node's performance evaluation.
 pub struct OrderedUnit<D: Data, H: Hasher> {
     pub data: Option<D>,
-    pub parents: Vec<(NodeIndex, H::Hash)>,
+    pub parents: Vec<H::Hash>,
     pub hash: H::Hash,
     pub creator: NodeIndex,
     pub round: Round,