Unify notation in grid.py #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unnecessary inputs to this function * Add coordinates to xarray dataset
* Previously, the iterative loop in _make_initial_lon_lat_ds did absoloutely nothing * This now correctly updates domain_lenght_in_degrees (rather than latitude_array_1d_in_degrees) * After correction, nx and ny need to be at least 2; code now raises a ValueError if this condition is not satisfied * Added also more comments
* Remove optimization loop; instead do only one iteration of Mercator projection * Fix bug in flipping coordinate procedure * Reorganize code to make it shorter and more readable
…en-initial-lon-lat
…-rotate-translation
* lone --> lonq * lon4 --> lon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No code changes, just cosmetics