Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix API issues in 2D Straight Skeletons (5.6.x) #8688

Open
wants to merge 22 commits into
base: 5.6.x-branch
Choose a base branch
from
Open

Fix API issues in 2D Straight Skeletons (5.6.x) #8688

wants to merge 22 commits into from

Conversation

MaelRL
Copy link
Member

@MaelRL MaelRL commented Jan 14, 2025 •
edited
Loading

Summary of Changes

Fix a number of doc / API issues in 2D straight skeletons, and add more tests.

TODO:

  • More API tests in weighted skeletons
  • 6.0.1 version to deal with boost::shared_ptr -> std::shared_ptr

Release Management

@MaelRL MaelRL added this to the 5.6.3 milestone Jan 14, 2025
@MaelRL MaelRL changed the title Fix wrong tparam name Fix API issues in 2D Straight Skeletons Jan 14, 2025
@MaelRL MaelRL mentioned this pull request Jan 15, 2025
Open
@MaelRL MaelRL changed the title Fix API issues in 2D Straight Skeletons Fix API issues in 2D Straight Skeletons (5.6.x) Jan 15, 2025
@MaelRL MaelRL removed the TODO label Jan 15, 2025
@MaelRL MaelRL linked an issue Jan 15, 2025 that may be closed by this pull request
something wrong with create_weighted_straight_skeleton_2.h #8686
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Doc bug Pkg::Straight_skeleton_2
Projects
None yet
Milestone
5.6.3
Development

Successfully merging this pull request may close these issues.

something wrong with create_weighted_straight_skeleton_2.h
1 participant
@MaelRL