Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triangulation 2/3: fstream -> sstream #8036

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

afabri
Copy link
Member

@afabri afabri commented Feb 16, 2024

Summary of Changes

Several . cpp use the same .h which write in a stream with the same name, which leads to errors when executed in parallel by ctest.

See these testsuites of Triangulation_3 and Triangulation_2

Release Management

  • Affected package(s): Triangulation_2, Triangulation_3
  • License and copyright ownership: unchanged

@sloriot
Copy link
Member

sloriot commented Feb 20, 2024

Successfully tested in CGAL-6.0-Ic-176

@lrineau lrineau assigned lrineau and unassigned afabri Feb 22, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Feb 22, 2024
@lrineau lrineau merged commit 7b07859 into CGAL:master Feb 22, 2024
8 checks passed
@lrineau lrineau deleted the T23-IOstringstream-GF branch February 22, 2024 09:31
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants