remove this redundant FPP directive #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschroeter
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Hi @JhanSrbinovsky, in what regard is this redundant? If it is declared higher up in the call hierarchy could you please point me to where this happens? Otherwise looks fine, just want to confirm before I tick it off. Cheers, Ben
|
Hey Ben, The dec is only local. There was an #ifdef() in this file, we are trying to to remove them all. I did. I removed the ifdef, but I forgot to remove the #define line |
|
@JhanSrbinovsky - good enough for me. Approved. |
bschroeter
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CABLE
Thank you for submitting a pull request to the CABLE Project.
Description
remove this redundant FPP directive.
Fixes #super quick one liner
Type of change
Please delete options that are not relevant.
Checklist
Please add a reviewer when ready for review.
📚 Documentation preview 📚: https://cable--508.org.readthedocs.build/en/508/