Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype pattern example #45

Merged
merged 4 commits into from
May 3, 2022
Merged

Prototype pattern example #45

merged 4 commits into from
May 3, 2022

Conversation

MiJey
Copy link
Contributor

@MiJey MiJey commented Mar 1, 2022 •
edited
Loading

Prototype 패턴의 예제를 작성하였습니다.

java.lang.Cloneable을 implement해서 clone() 메서드를 구현하고, Kotlin data class의 copy() 메서드를 활용하여 내부 개체들의 깊은 복사를 하였습니다.

CheckList

  • Documentation: 주석에 포함
  • Self reviewed

Done

#5

@MiJey MiJey requested a review from yangkyeongmo March 1, 2022 22:43
@MiJey MiJey self-assigned this Mar 1, 2022
@MiJey MiJey changed the title Impelement prototype pattern example Prototype pattern example Mar 2, 2022
Taek-Gu
Taek-Gu approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@Taek-Gu Taek-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~! Kotlin은 clone을 위한 상위 인터페이스를 따로 안 만들어도 돼서 예제가 간결하네요.

@muuty muuty self-requested a review May 2, 2022 12:09
muuty
muuty approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@muuty muuty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ 설명이 상세해서 읽기 편했습니다!

@gwolves gwolves merged commit 363178a into main May 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the prototype-pattern-example-nike branch May 3, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwolves gwolves gwolves approved these changes

@Taek-Gu Taek-Gu Taek-Gu approved these changes

@muuty muuty muuty approved these changes

@yangkyeongmo yangkyeongmo Awaiting requested review from yangkyeongmo

Assignees

@MiJey MiJey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MiJey @gwolves @Taek-Gu @muuty