forked from mattermost/mattermost-plugin-mscalendar
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MI-2705]:Added summary for status sync job #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavaggarwal2308
requested changes
Feb 2, 2023
ayusht2810
reviewed
Feb 2, 2023
ayusht2810
approved these changes
Feb 3, 2023
manojmalik20
reviewed
Feb 6, 2023
manojmalik20
approved these changes
Feb 6, 2023
Kshitij-Katiyar
added a commit
that referenced
this pull request
Apr 12, 2023
…ppens for a single user" by added additional logging (mattermost#245) * [MI-2664]:Fixed issue mattermost#244 on ms calender to add additional logging (#2) * [MI-2664]:Fixed issue mattermost#244 on ms calender to add additional logging * [MI-2664]:Added comment for skipping user * [MI-2664]:Fixed unit test cases * [MI-2664]:Fix lint errors * [MI-2664]:Added conditional logging * [MI-2664]:Added constants for limit * [MI-2664]:Fixed review comments * [MI-2664]:Fixed review comments * [MI-2687]:Fixed review comments given by mattermost team on issue#244 of mscalender plugin (#3) * [MI-2687]:Fixed review comments given by mattermost team on issue mattermost#244 of mscalender plugin * [MI-2687]:Fixed unit test cases * [MI-2687]:Fixed review fixes * [MI-2705]:Added summary for status sync job (#4) * [MI-2705]:Added summary for status sync job * [MI-2705]:Fixed review comments * Fixed lint errors (mattermost#243) * [MI-2705]:Fixed review comments * [MI-2705]:Fixed review comments --------- Co-authored-by: Manoj Malik <manoj@brightscout.com> * [MM-244]:Fixed lint errors * [MM-244]:Added a check for summary to be nill * [MM-244]:Added addtional check for user error * [MM-244]:Fixed lint errors * [MM-244]:Fixed review comments --------- Co-authored-by: Manoj Malik <manoj@brightscout.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mattermost#245 (comment)