Skip to content

Commit

Permalink
core: Remove unused helper field from SubchannelImpl
Browse files Browse the repository at this point in the history
  • Loading branch information
ejona86 committed Jan 17, 2023
1 parent 42ba00b commit 62d9247
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions core/src/main/java/io/grpc/internal/ManagedChannelImpl.java
Original file line number Diff line number Diff line change
Expand Up @@ -1461,7 +1461,7 @@ public AbstractSubchannel createSubchannel(CreateSubchannelArgs args) {
syncContext.throwIfNotInThisSynchronizationContext();
// No new subchannel should be created after load balancer has been shutdown.
checkState(!terminating, "Channel is being terminated");
return new SubchannelImpl(args, this);
return new SubchannelImpl(args);
}

@Override
Expand Down Expand Up @@ -1933,7 +1933,6 @@ private void scheduleExponentialBackOffInSyncContext() {

private final class SubchannelImpl extends AbstractSubchannel {
final CreateSubchannelArgs args;
final LbHelperImpl helper;
final InternalLogId subchannelLogId;
final ChannelLoggerImpl subchannelLogger;
final ChannelTracer subchannelTracer;
Expand All @@ -1943,7 +1942,7 @@ private final class SubchannelImpl extends AbstractSubchannel {
boolean shutdown;
ScheduledHandle delayedShutdownTask;

SubchannelImpl(CreateSubchannelArgs args, LbHelperImpl helper) {
SubchannelImpl(CreateSubchannelArgs args) {
checkNotNull(args, "args");
addressGroups = args.getAddresses();
if (authorityOverride != null) {
Expand All @@ -1952,7 +1951,6 @@ private final class SubchannelImpl extends AbstractSubchannel {
args = args.toBuilder().setAddresses(eagsWithoutOverrideAttr).build();
}
this.args = args;
this.helper = checkNotNull(helper, "helper");
subchannelLogId = InternalLogId.allocate("Subchannel", /*details=*/ authority());
subchannelTracer = new ChannelTracer(
subchannelLogId, maxTraceEvents, timeProvider.currentTimeNanos(),
Expand Down

0 comments on commit 62d9247

Please sign in to comment.