fix IPC

neurots/generate/orientations.py

@@ -294,26 +294,21 @@ def propose(_):
 
         def prob(proposal):
             """Probability function to accept a trunk angle."""
-            val = nm.morphmath.angle_between_vectors(Y_DIRECTION, proposal)
+            val = nm.morphmath.angle_between_vectors(ref_dir, proposal)
             _prob = get_probability_function(
                 form=self._parameters[tree_type]["orientation"]["values"]["form"],
                 with_density=False,
             )
             params = self._parameters[tree_type]["orientation"]["values"]["params"]
             p = _prob(val, *params)
 
-            if self._context is not None and self._context.get(
-                "constraints", []
-            ):  # pragma: no cover
+            if self._context.get("constraints", []):  # pragma: no cover
                 for constraint in self._context["constraints"]:
                     if "trunk_prob" in constraint:
                         p *= constraint["trunk_prob"](proposal, self._soma.center)
             return p
 
-        res = accept_reject(propose, prob, self._rng, max_tries=max_tries)
-        if ref_dir is not None and res is not None:
-            res = rotation.rotation_matrix_from_vectors(Y_DIRECTION, ref_dir).dot(res)
-        return res
+        return accept_reject(propose, prob, self._rng, max_tries=max_tries)
 
 
 def spherical_angles_to_orientations(phis, thetas):

neurots/generate/section.py

@@ -97,9 +97,6 @@ def _propose(self, extra_randomness=0, add_random_component=True):
 
         if add_random_component:
             random_component = self.params.randomness * get_random_point(random_generator=self._rng)
-            # this is needed only to get 100% invariance under y_direction
-            # if self.context.get("y_rotation") is not None:
-            #    random_component = self.context["y_rotation"].dot(random_component)
             if extra_randomness > 0:  # pragma: no cover
                 random_component *= extra_randomness
             direction += random_component

neurots/generate/tree.py

@@ -165,7 +165,7 @@ def add_section(
         """
         SGrower = section_growers[self.params["metric"]]
         context = copy.deepcopy(self.context)
-        if self.context is not None and "constraints" in self.context:  # pragma: no cover
+        if "constraints" in self.context:  # pragma: no cover
             context["constraints"] = [
                 constraint
                 for constraint in self.context["constraints"]