Unblock execute command if no output is requested #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkervella
approved these changes
Mar 7, 2023
|
Thanks for taking care of it, I ended up being busy last night :) |
|
🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #1130 , reap zombies but don't block.
As an operator using an interactive session, I want to be able to run a command like
execute /bin/bash -c 'sleep 10'without having to wait for it to finish, because I need a way to launch long-running processes without making the session unusable.Waiting for the command in a separate Goroutine allows to return from the task immediately while making sure no defunct processes are left over.