Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #770 from tschettervictor/patch-7" #779

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

yaazkal
Copy link
Collaborator

@yaazkal yaazkal commented Dec 29, 2024

This reverts commit 649c337, reversing changes made to 7d3ca7b in PR #770

The reason to revert this is because that PR introduces an issue when the templates are not applied anymore.

Take this as an example:

Does not apply the base templates at the creation time nor a custom template:
image

After reverting the commit, the previous behavior was recovered at creation time:
image

After reverting the commit, the previous capability of applying an extra template was recovered:
image

This reverts commit 649c337, reversing
changes made to 7d3ca7b.
@yaazkal yaazkal merged commit cc78213 into master Dec 29, 2024
1 check passed
@yaazkal yaazkal deleted the revert-pr-770 branch December 29, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants