Reverting nested models for create/update #932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Nested @model definitions shouldn't be supported, otherwise the engine will need to find some way to extract that out - Added Snapshooter to make testing a generated GraphQL schema a lot easier - Note - Snapshooter is used by HotChocolate extensively in its tests - Snapshooter hasn't shipped a NuGet package for MSTest support, so code is embedded (I wrote the MSTest support so I know it works!) - Added tests and their snapshots for the GraphQL schema structures that need to be covered
…-api-builder into aaronpowell/issue-906
|
Supporting nested @model on create/update poses a complex problem in the runtime, as the runtime will need to extract the sub-objects to modify the corresponding object within the database This makes sense. Let us support nested mutations only for representative objects and not objects annotated with @model. @aaronpowell Isnt the existing implementation good without if we just make sure that the object is not annotated with @model and annotate it? |
|
Closing for now since this is old, can reopen if revisited with merge conflicts resolved to accommodate the changes that have been added since this was opened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
@modelon create/update poses a complex problem in the runtime, as the runtime will need to extract the sub-objects to modify the corresponding object within the database@modeltypes, as they are ones that aren't stored in a separate database/collection in Cosmos- Snapshooter doesn't have MS Test support shipping on NuGet (I wrote it while addressing this bug). It's been merged and is just waiting for a NuGet package, so presently the code is embedded in the DAB codebaseHow was this tested?
@model <-> @model), and nested object types (@model <-> non-@model)