Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle only deleted files in a <language> - pullrequest build #9658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jan 17, 2025

In action

I think the only real discussion item here is whether to fold the deleted files directly under ChangedFiles. I prefer it to be separate, as we can rely on ChangedFiles actually resolving to a reference on disk. However for this usage it doesn't actually matter, as we don't rely on them existing on disk to check which package they belong to in Get-PrPackageProperties.

Pending feedback from @weshaggard or @benbp , I have an opinion but I know ya'll will have one as well 👍

@kristapratico when I merge this (regardless of implementation detail) this PR will resolve the issue you saw over here.

@scbedd scbedd requested a review from a team as a code owner January 17, 2025 21:24
@scbedd scbedd self-assigned this Jan 17, 2025
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔬 Dev in PR
Development

Successfully merging this pull request may close these issues.

3 participants