Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compute] GalleryImageVersion Powershell commands to support BlockDeletionBeforeEndOfLife parameter. #27210

Closed

Conversation

haagha
Copy link
Member

@haagha haagha commented Feb 24, 2025

Description

resolves /~https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1473

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@haagha
Copy link
Member Author

haagha commented Feb 24, 2025

/azp run

1 similar comment
@VeryEarly
Copy link
Collaborator

/azp run

@NoriZC NoriZC added the Compute label Feb 25, 2025
@NoriZC
Copy link
Contributor

NoriZC commented Feb 25, 2025

@haagha the PR status is not good which cause the PR Validation not trigger. We have adjust the PR process, you need to create a new branch from latest main branch and cherry pick your updates:
git fetch Azure main
git checkout -b xxx Azure/main
git fetch origin cmdassistant-1473-12658771989-1
git cherry-pick 4f906ac
git cherry-pick 4257300
git cherry-pick c9959ff

Then raise a new PR to replace current one.

@haagha haagha closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants