Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Az.Migrate:Data.Replication - Update API version and Rebrand to Azure Local #27185

Closed
wants to merge 13 commits into from

Conversation

helen-afework
Copy link
Contributor

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@helen-afework
Copy link
Contributor Author

@NoriZC
Copy link
Contributor

NoriZC commented Feb 21, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@NoriZC
Copy link
Contributor

NoriZC commented Feb 21, 2025

@helen-afework Please make sure you are following https://gist.github.com/VeryEarly/53cf3372a1c7c7c6f5e1ffd3949513a5 to do the development. As I see that there are something missed in your PR right now.

@NoriZC NoriZC self-assigned this Feb 21, 2025
Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

Hi @helen-afework , status of this PR doesn't look correct, please do following

cd src/Migrate/Migrate.Autorest
autorest --reset
autorest
build-module.ps1
cd ..
git add .
git commit -m "xxx"
git push origin head

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants