Add Managed Identity Support in Azure Disk Encryption for VMSS #27008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshuljain26
requested review from
bilaakpan-ms,
Sandido,
haagha and
grizzlytheodore
as code owners
️✔️Az.Accounts
|
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| New-AzVmssConfig | 1 | 1 | Unassigned_Variable | New-AzVmssConfig -Location $Loc is a null-valued parameter value. | -Location | Assign value for $Loc. | |
| New-AzVmssConfig | 1 | 1 | Unassigned_Variable | New-AzVmssConfig -NetworkInterfaceConfiguration $NetCfg is a null-valued parameter value. | -NetworkInterfaceConfiguration | Assign value for $NetCfg. | |
| New-AzVmssConfig | 1 | 2 | Unassigned_Variable | Add-AzVmssNetworkInterfaceConfiguration -IPConfiguration $IPCfg is a null-valued parameter value. | -IPConfiguration | Assign value for $IPCfg. | |
| New-AzVmssConfig | 1 | 3 | Unassigned_Variable | Set-AzVmssOsProfile -AdminUsername $adminUsername is a null-valued parameter value. | -AdminUsername | Assign value for $adminUsername. | |
| New-AzVmssConfig | 1 | 3 | Unassigned_Variable | Set-AzVmssOsProfile -AdminPassword $AdminPassword is a null-valued parameter value. | -AdminPassword | Assign value for $AdminPassword. | |
| New-AzVmssConfig | 1 | 5 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferenceOffer $ImgRef.Offer is a null-valued parameter value. | -ImageReferenceOffer | Assign value for $ImgRef.Offer. | |
| New-AzVmssConfig | 1 | 5 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferenceSku $ImgRef.Skus is a null-valued parameter value. | -ImageReferenceSku | Assign value for $ImgRef.Skus. | |
| New-AzVmssConfig | 1 | 5 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferenceVersion $ImgRef.Version is a null-valued parameter value. | -ImageReferenceVersion | Assign value for $ImgRef.Version. | |
| New-AzVmssConfig | 1 | 6 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferencePublisher $ImgRef.PublisherName is a null-valued parameter value. | -ImageReferencePublisher | Assign value for $ImgRef.PublisherName. | |
| New-AzVmssConfig | 1 | 6 | Unassigned_Variable | Set-AzVmssStorageProfile -VhdContainer $VHDContainer is a null-valued parameter value. | -VhdContainer | Assign value for $VHDContainer. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -ComponentName $AUCComponentName is a null-valued parameter value. | -ComponentName | Assign value for $AUCComponentName. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -Content $AUCContent is a null-valued parameter value. | -Content | Assign value for $AUCContent. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -PassName $AUCPassName is a null-valued parameter value. | -PassName | Assign value for $AUCPassName. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -SettingName $AUCSetting is a null-valued parameter value. | -SettingName | Assign value for $AUCSetting. | |
| New-AzVmssConfig | 1 | 9 | Unassigned_Variable | New-AzVmss -ResourceGroupName $RGName is a null-valued parameter value. | -ResourceGroupName | Assign value for $RGName. | |
| New-AzVmssConfig | 1 | 9 | Unassigned_Variable | New-AzVmss -Name $VMSSName is a null-valued parameter value. | -Name | Assign value for $VMSSName. | |
| New-AzVmssConfig | 4 | 18 | Unassigned_Variable | New-AzStorageAccount -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 18 | Unassigned_Variable | New-AzStorageAccount -Location $loc is a null-valued parameter value. | -Location | Assign value for $loc. | |
| New-AzVmssConfig | 4 | 19 | Unassigned_Variable | Get-AzStorageAccount -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 23 | Unassigned_Variable | New-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 23 | Unassigned_Variable | New-AzVirtualNetwork -Location $loc is a null-valued parameter value. | -Location | Assign value for $loc. | |
| New-AzVmssConfig | 4 | 24 | Unassigned_Variable | Get-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 30 | Unassigned_Variable | New-AzVmssConfig -Location $loc is a null-valued parameter value. | -Location | Assign value for $loc. | |
| New-AzVmssConfig | 4 | 32 | Unassigned_Variable | Set-AzVmssOsProfile -AdminPassword $password is a null-valued parameter value. | -AdminPassword | Assign value for $password. | |
| New-AzVmssConfig | 4 | 37 | Unassigned_Variable | New-AzVmss -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 39 | Unassigned_Variable | Get-AzVmss -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 5 | 36 | Mismatched_Parameter_Value_Type | Set-AzVmssOsProfile -AdminPassword $adminPassword is not an expected parameter value type. | -AdminPassword | Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command). |
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Example | Line | RuleName | Description | Extent | Remediation |
|---|---|---|---|---|---|---|---|
| New-AzVmssConfig | 1 | 1 | Unassigned_Variable | New-AzVmssConfig -Location $Loc is a null-valued parameter value. | -Location | Assign value for $Loc. | |
| New-AzVmssConfig | 1 | 1 | Unassigned_Variable | New-AzVmssConfig -NetworkInterfaceConfiguration $NetCfg is a null-valued parameter value. | -NetworkInterfaceConfiguration | Assign value for $NetCfg. | |
| New-AzVmssConfig | 1 | 2 | Unassigned_Variable | Add-AzVmssNetworkInterfaceConfiguration -IPConfiguration $IPCfg is a null-valued parameter value. | -IPConfiguration | Assign value for $IPCfg. | |
| New-AzVmssConfig | 1 | 3 | Unassigned_Variable | Set-AzVmssOsProfile -AdminUsername $adminUsername is a null-valued parameter value. | -AdminUsername | Assign value for $adminUsername. | |
| New-AzVmssConfig | 1 | 3 | Unassigned_Variable | Set-AzVmssOsProfile -AdminPassword $AdminPassword is a null-valued parameter value. | -AdminPassword | Assign value for $AdminPassword. | |
| New-AzVmssConfig | 1 | 5 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferenceOffer $ImgRef.Offer is a null-valued parameter value. | -ImageReferenceOffer | Assign value for $ImgRef.Offer. | |
| New-AzVmssConfig | 1 | 5 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferenceSku $ImgRef.Skus is a null-valued parameter value. | -ImageReferenceSku | Assign value for $ImgRef.Skus. | |
| New-AzVmssConfig | 1 | 5 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferenceVersion $ImgRef.Version is a null-valued parameter value. | -ImageReferenceVersion | Assign value for $ImgRef.Version. | |
| New-AzVmssConfig | 1 | 6 | Unassigned_Variable | Set-AzVmssStorageProfile -ImageReferencePublisher $ImgRef.PublisherName is a null-valued parameter value. | -ImageReferencePublisher | Assign value for $ImgRef.PublisherName. | |
| New-AzVmssConfig | 1 | 6 | Unassigned_Variable | Set-AzVmssStorageProfile -VhdContainer $VHDContainer is a null-valued parameter value. | -VhdContainer | Assign value for $VHDContainer. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -ComponentName $AUCComponentName is a null-valued parameter value. | -ComponentName | Assign value for $AUCComponentName. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -Content $AUCContent is a null-valued parameter value. | -Content | Assign value for $AUCContent. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -PassName $AUCPassName is a null-valued parameter value. | -PassName | Assign value for $AUCPassName. | |
| New-AzVmssConfig | 1 | 7 | Unassigned_Variable | Add-AzVmssAdditionalUnattendContent -SettingName $AUCSetting is a null-valued parameter value. | -SettingName | Assign value for $AUCSetting. | |
| New-AzVmssConfig | 1 | 9 | Unassigned_Variable | New-AzVmss -ResourceGroupName $RGName is a null-valued parameter value. | -ResourceGroupName | Assign value for $RGName. | |
| New-AzVmssConfig | 1 | 9 | Unassigned_Variable | New-AzVmss -Name $VMSSName is a null-valued parameter value. | -Name | Assign value for $VMSSName. | |
| New-AzVmssConfig | 4 | 18 | Unassigned_Variable | New-AzStorageAccount -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 18 | Unassigned_Variable | New-AzStorageAccount -Location $loc is a null-valued parameter value. | -Location | Assign value for $loc. | |
| New-AzVmssConfig | 4 | 19 | Unassigned_Variable | Get-AzStorageAccount -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 23 | Unassigned_Variable | New-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 23 | Unassigned_Variable | New-AzVirtualNetwork -Location $loc is a null-valued parameter value. | -Location | Assign value for $loc. | |
| New-AzVmssConfig | 4 | 24 | Unassigned_Variable | Get-AzVirtualNetwork -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 30 | Unassigned_Variable | New-AzVmssConfig -Location $loc is a null-valued parameter value. | -Location | Assign value for $loc. | |
| New-AzVmssConfig | 4 | 32 | Unassigned_Variable | Set-AzVmssOsProfile -AdminPassword $password is a null-valued parameter value. | -AdminPassword | Assign value for $password. | |
| New-AzVmssConfig | 4 | 37 | Unassigned_Variable | New-AzVmss -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 4 | 39 | Unassigned_Variable | Get-AzVmss -ResourceGroupName $rgname is a null-valued parameter value. | -ResourceGroupName | Assign value for $rgname. | |
| New-AzVmssConfig | 5 | 36 | Mismatched_Parameter_Value_Type | Set-AzVmssOsProfile -AdminPassword $adminPassword is not an expected parameter value type. | -AdminPassword | Use correct parameter value type. Expected Type is string. Now the type is securestring.(Command). |
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Maintenance
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Ssh
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
|
@vimish Please review the PR |
added 2 commits
January 15, 2025 12:50
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
YanaXu
reviewed
Jan 16, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Azure Disk Encryption (ADE) is adding support for using managed identity to authenticate to customer's keyvault.
As part of it, a new field (EncryptionIdentity) has been added to the VM model. By setting this field customer will be notifying ADE to use that managed identity for keyvault operations. The identity should also be explicitly assigned to the VMSS.
This PR adds a new parameter (EncryptionIdentity) to Set-AzVmssDiskEncryptionExtension cmdlet. If the parameter is present then the cmdlet will ensure that identity is assigned to the VMSS and the EncryptionIdentity field is updated.
Encryption Identity field is also updated during VMSS creation if the encryption identity is a part of the identities assigned to the vm.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.