Generation of GA PowerShell module for Workloads 2024-09-01 api #26228
Conversation
* Add WIF changes back * Run Autorest and build again
…zure#26031) * Implement ResourceSelector and Override parameters for New/Update-AzPolicyAssignment Implement ResourceSelector parameter for New/Update-AzPolicyExemption Add new tests for selectors and overrides Add new examples for selectors and overrides * Rerecord tests * Fix two examples to contain only powershell commands * Rebuild docs * Switch tag new tests as -LiveOnly
…zure#26122) * Support CRC check for volume groups * Hide ManagedByResourceId in update volume * remove personal info from recording files
…PREVIEW (Azure#26115) * Powershell : Release for MicrosoftCache.RedisEnterprise - 2024-09-01 Preview * Make object id as required * add re executed tests recordings --------- Co-authored-by: Priyankar Gupta <priyagupta@microsoft.com>
* Fix: remove enable gateway flag and quit on error * fixes 2 * refactor existing config flag and info on screen * update examples * update output and remove duplicated helm option * use write-output and rebuild
* create Upcoming breaking change message * create BreakingChangeIssues.csv
Co-authored-by: azurepowershell <azurepowershell@ms.com>
* generate code * add license profile and network configuration cmdlet * remove license profile and network configuration * remove NSP PATCH test * test * test * custom cmdlet * update * test * test * test * Fix static analysis error * Generate using autorest.powershell 4.0.712 * Generate help using autorest.powershell 4.0.715 --------- Co-authored-by: Lei Jin <leijin@microsoft.com>
️✔️Az.Accounts
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzWorkloadsMonitor | Get-AzWorkloadsMonitor Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWorkloadsMonitor | Get-AzWorkloadsMonitor changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWorkloadsProviderInstance | Get-AzWorkloadsProviderInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWorkloadsProviderInstance | Get-AzWorkloadsProviderInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWorkloadsSapApplicationInstance | Get-AzWorkloadsSapApplicationInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWorkloadsSapApplicationInstance | Get-AzWorkloadsSapApplicationInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWorkloadsSapCentralInstance | Get-AzWorkloadsSapCentralInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWorkloadsSapCentralInstance | Get-AzWorkloadsSapCentralInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWorkloadsSapDatabaseInstance | Get-AzWorkloadsSapDatabaseInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWorkloadsSapDatabaseInstance | Get-AzWorkloadsSapDatabaseInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWorkloadsSapLandscapeMonitor | Get-AzWorkloadsSapLandscapeMonitor Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWorkloadsSapLandscapeMonitor | Get-AzWorkloadsSapLandscapeMonitor changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzWorkloadsSapVirtualInstance | Get-AzWorkloadsSapVirtualInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzWorkloadsSapVirtualInstance | Get-AzWorkloadsSapVirtualInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzWorkloadsProviderDB2InstanceObject | New-AzWorkloadsProviderDB2InstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzWorkloadsProviderHanaDbInstanceObject | New-AzWorkloadsProviderHanaDbInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzWorkloadsProviderPrometheusHaClusterInstanceObject | New-AzWorkloadsProviderPrometheusHaClusterInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzWorkloadsProviderPrometheusOSInstanceObject | New-AzWorkloadsProviderPrometheusOSInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzWorkloadsProviderSapNetWeaverInstanceObject | New-AzWorkloadsProviderSapNetWeaverInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzWorkloadsProviderSqlServerInstanceObject | New-AzWorkloadsProviderSqlServerInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzWorkloadsSapLandscapeMonitorMetricThresholdsObject | New-AzWorkloadsSapLandscapeMonitorMetricThresholdsObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzWorkloadsSapLandscapeMonitorSidMappingObject | New-AzWorkloadsSapLandscapeMonitorSidMappingObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Workloads. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.
|
/azp run |
|
Commenter does not have sufficient privileges for PR 26228 in repo Azure/azure-powershell |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 86 out of 86 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/Workloads/SapVirtualInstance.Autorest/docs/Get-AzWorkloadsSapVirtualInstance.md:33
- [nitpick] The renaming swap between the list commands (from 'List1' to 'List' and vice versa) could be confusing; consider using more descriptive names to clearly distinguish their purposes.
### List1
src/Workloads/SapVirtualInstance.Autorest/custom/New-AzWorkloadsSapVirtualInstance/New-AzWorkloadsSapVirtualInstance_CreateWithJsonString.cs:18
- Verify that the output type change from 'Api20231001Preview' to 'Api20240901' is correctly and consistently applied throughout all related components to avoid potential mismatches.
[global::System.Management.Automation.OutputType(typeof(Microsoft.Azure.PowerShell.Cmdlets.Workloads.SapVirtualInstance.Models.Api20240901.ISapVirtualInstance))]
src/Workloads/SapVirtualInstance.Autorest/docs/Invoke-AzWorkloadsSapDiskConfiguration.md
Show resolved
Hide resolved
|
To improve dev experience and reduce maintenance efforts, we are deprecating branch: generation now. Azure-PowerShell modules generated by autorest.powershell no longer target branch generation, and will be targeting directly to main instead. Please find migration guide and document below: If you have open PR or on going development |
NoriZC
added
the
Legacy
|
To improve dev experience and reduce maintenance efforts, we are deprecating branch: generation now. Azure-PowerShell modules generated by autorest.powershell no longer target branch generation, and will be targeting directly to main instead. Please find migration guide and document below: |
Hello @JoyerJin , I tried to create PR with main branch but it is showing lot of changes and conflicts(#27206), looks like a lot of work needs to be done. We need this new GA version to be part of release train starting tomorrow. Do we have any work arounds? Regards, |
Please follow the 'If your PR contains changes for autogen modules only' Guidance steps. Thank you, you can post issues which you met on our channel to solve. |
Thanks a lot for the help. create new PR after migrating to new process. ##27209 |
|
Replaced by #27209 Thanks! |
Description
Generation of GA PowerShell module for Workloads 2024-09-01 api
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.