Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Ambiguous Positional Argument for #23888

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

Marty-Me
Copy link
Contributor

@Marty-Me Marty-Me commented Jan 5, 2024

Description

New-AzWebAppSlot had the same configured Position for two different arguments, resulting in an AmbiguousPositionalParameterNoName error. This PR configures one of the two parameters with overlapping position to use the next one.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Jan 5, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Copy link
Contributor

Thank you for your contribution Marty-Me! We will review the pull request and get back to you soon.

@Marty-Me
Copy link
Contributor Author

Marty-Me commented Jan 5, 2024

@microsoft-github-policy-service agree

@Marty-Me Marty-Me force-pushed the fix/ambiguous-paramter-position branch from 287b5fd to 7c1f9bf Compare January 5, 2024 17:15
@@ -73,7 +73,7 @@ public class NewAzureWebAppSlotCmdlet : WebAppBaseClientCmdLet
[ValidateNotNullOrEmpty]
public string AseName { get; set; }

[Parameter(Position = 9, Mandatory = false, HelpMessage = "Resource group of Application Service environment")]
[Parameter(Position = 10, Mandatory = false, HelpMessage = "Resource group of Application Service environment")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the position of a paramter will cause breaking changes. We need to follow the breaking change process.

@wyunchi-ms wyunchi-ms added App Services aka WebSites Breaking Change Release This PR contains breaking change labels Jan 8, 2024
Copy link

github-actions bot commented Jan 8, 2024

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@wyunchi-ms wyunchi-ms merged commit 2869b97 into Azure:main Jan 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Services aka WebSites Breaking Change Release This PR contains breaking change customer-reported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants