Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing V2 template install option #2153

Merged
merged 1 commit into from
Dec 15, 2017
Merged

Fixing V2 template install option #2153

merged 1 commit into from
Dec 15, 2017

Conversation

ammanifold
Copy link
Contributor

fixes #2150

image

hartra344
hartra344 approved these changes Dec 13, 2017
View reviewed changes
Copy link
Contributor

@hartra344 hartra344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy

ahmelsayed
ahmelsayed approved these changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@ahmelsayed ahmelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Ideally you'd have a type other than any, but I've already changed that in my other PR, so you'll get it for free

:shipit:

@ahmelsayed ahmelsayed merged commit dff917a into master Dec 15, 2017
@ammanifold ammanifold deleted the algrunin-hotfixV2 branch January 30, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartra344 hartra344 hartra344 approved these changes

@ahmelsayed ahmelsayed ahmelsayed approved these changes

@paulbatum paulbatum Awaiting requested review from paulbatum

@alrod alrod Awaiting requested review from alrod

@ehamai ehamai Awaiting requested review from ehamai ehamai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ammanifold @ahmelsayed @hartra344