Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Algorithm for Memory Depth in FSM #1233
Algorithm for Memory Depth in FSM #1233
Changes from 8 commits
94ebbee
193e8ab
b1be726
0822b5c
395a040
2caf106
7294426
080bf8c
d0769e8
0e6803e
ffc319a
b8e2b44
b603e7e
95a1d13
ebbcf73
8d22d95
f2340ad
2e3c7e4
d5e2b43
0a62b74
9df30e3
87792a2
b4e6c41
6763610
f5d6129
28f90ae
222759e
50e8284
9cae641
676b722
3ad5c16
4ea47e8
1f6a168
c4358f9
7f8f246
a081ad8
a348e2a
2d2a1ea
136864c
f96fa4e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move these classes out of the function, it doesn't seem like they use any local data in their definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right that they could be moved outside of the function without problem. My reasoning for leaving them in the function is because they're not used anywhere else, and my feeling is that it's similar to a local variable, which could be made global, but encapsulation is better. I know this is a contentious point though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to see these classes outside the function and with unit tests for their behaviour.