-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tricky Level Punisher #1178
Add Tricky Level Punisher #1178
Conversation
Rather than update the meta player tests each time, which amounts to a "change detector test" at the moment and can be a pain to update, we might consider simply having a test for the number of team members. |
I am happy to fix the tests for the meta players in a different |
Yeah great call @marcharper, perhaps not just the number but a test of the makeup of the tea (specific members?) also good to have a test that matches complete too. (@Nikoleta-v3 if you could handle this that'd be great 👍) #1177 is merged so you should be ok to rebase. |
The behaviour of MetaMajorityLongMemory has now changed because Tricky Level Punisher is on the strategy's team.
Thanks @Nikoleta-v3 merging this in 👍 |
I picked up #1132 which implements a strategy called Tricky Level Punisher.
The
pr
was failing due a division by zero error. Moreover, I had to tweak the tests ofMetaMajorityLongMemory
because nowTrickyLevelPunisher
is in the strategy's team.Note that this
pr
will fail due to #1176, I will rebase once #1177 is merged.