Implement AddOrUpdateRange method in ResourceDictionary #18354
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
the
needs-api-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR provides a new method to the ResourceDictionary called
AddOrUpdateRangewhich allows to batch multiple updates in one go and notify all subscribers about the change at the very end once the resources have been updated.See discussion: #18346
What is the current behavior?
At the moment, adding or updating existing resources are immediately notifying all subscribers about resource changes. In complex application this can become quite expensive and slow when your updating multiple (tens or hundreds) resources by code.
What is the updated/expected behavior with this PR?
When using the
AddOrUpdateRangemethods, the notification of all subscribers happens only once at the end of the method, regardless of the number of updates performed.Checklist
Breaking changes
None.
Obsoletions / Deprecations
None.
Fixed issues
#18346