-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developer: Network Debugging #1813
Conversation
Generated by 🚫 Danger |
# Conflicts: # podcasts/DatabaseExport.swift
📲 You can test the changes from this Pull Request in Pocket Casts Prototype Build by scanning the QR code below to install the corresponding build.
|
@leandroalonso I tried several different ways to reference the Pulse Swift Package only in Release builds but none of them seemed to work. I've just moved it to Cocoapods for now. I verified it wasn't included by checking for symbols using Hopper: |
Don't really agree with this but it satisfies dangermattic
456e5b9
to
ab68cff
Compare
@bjtitus Nice! The test target is failing though. 🔴 |
Good to go now @leandroalonso and @SergioEstevao! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition to our debug tools!
It could be very helpful to find issues when streaming files and see request results on the context of playback skipping.
In general the tool is working correctly and I just found a crash but I think it's on Pulse codebase.
Steps to reproduce:
- Go to Network Debug
- Tap on Filters and select group by host
- On a Group tap on See All,
- See it crash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just left a comment regarding a crash that I think is part of the PulseUI library itself.
Thanks @SergioEstevao! I reproduced the crash and filed an issue (kean/Pulse#263) on Pulse. |
Adds Pulse network logging framework.
Simulator.Screen.Recording.-.iPhone.13.mini.-.2024-06-06.at.14.24.00.mp4
To test
Network debugging
networkDebugging
flag in Beta FeaturesExported Logs
network.pulse
file existsChecklist
CHANGELOG.md
if necessary.