region option #108
Closed
region option #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…property in 'auth'
|
Awesome! Recovering from EmpireJS at the moment, but will try to review and merge either tomorrow or the next day. |
|
Cool. FYI the bucketUsWest2 test bucket must indeed be created in us-west-2 specifically, I misspoke earlier when I said it could be in any bucket but us-standard. That region name is coded in the test. |
|
Merged as e7b23e6. Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
region option implemented, documented & tested. See issue #95. Note: expects an additional property in 'auth' called bucketUsWest2. This must be the name of a bucket that was created in the us-west-2 region (well... any region except us-standard actually). This is used to verify that putFile works properly when the region option is present. Someday, if issue #66 is resolved, putFile will also work properly without specifying region, however it's probably a good idea to specify it all the time to avoid the overhead of a redirect.