SyntheSimJava Documentation #1094
Conversation
azaleacolburn
requested review from
a-crowell,
LucaHaverty,
PepperLola and
BrandonPacewic
and removed request for
a team
simulation/SyntheSimJava/src/main/java/com/autodesk/synthesis/revrobotics/CANSparkMax.java
Show resolved
Hide resolved
...ion/SyntheSimJava/src/main/java/com/autodesk/synthesis/revrobotics/SparkAbsoluteEncoder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I think it's worth changing the Java comments to use the Javadoc format so people who use the library can get intellisense native to their editor.
…revrobotics/CANSparkMax.java Co-authored-by: PepperLola <PepperLola@users.noreply.github.com>
…revrobotics/SparkAbsoluteEncoder.java Co-authored-by: PepperLola <PepperLola@users.noreply.github.com>
simulation/SyntheSimJava/src/main/java/com/autodesk/synthesis/ctre/TalonFX.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I think it looks good now. I made some changes that you're free to revert if you want.
Edit: It looks like I introduced a merge conflict by adding a class comment. I think that should stay there but maybe the import should be removed if it was added in this PR?
There was a problem hiding this comment.
I think it looks good now. I made some changes that you're free to revert if you want.
Edit: It looks like I introduced a merge conflict by adding a class comment. I think that should stay there but maybe the import should be removed if it was added in this PR?
The merge conflict was just due to this branch not being up to date with dev where that commented import was already removed.
Looks good to go as long as @azaleacolburn is ok with the pushed changes ✅
Description
Documentation for SyntheSimJava
Let me know if anything else should be added.
No JIRA Issue