-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AARD-1735: Logging module updates #1010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question about a comment, otherwise, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. It created new log files each time and correctly logged debug information. Timing looks like it works. I got an error setting the export destination to upload and it sent a message box and logged it.
@timed
decorator to functions added in AARD-1687: Save exporter options with active design #981 to track performance concerns.try
andexcept
s that were all leading intologger.error
andui.messageBox
error messages.Important
Blocked by AARD-1685: Joint Config Panel #995.JIRA Issue