Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AARD-1735: Logging module updates #1010

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Conversation

BrandonPacewic
Copy link
Member

@BrandonPacewic BrandonPacewic commented Jul 3, 2024

  • Added logging file history:
    • The past 10 log files will now be saved.
  • Removed old analytics and timing system.
  • Improved / added timing and performance based logging:
  • Created a wrapper to avoid global try and excepts that were all leading into logger.error and ui.messageBox error messages.

JIRA Issue

@BrandonPacewic BrandonPacewic marked this pull request as ready for review July 22, 2024 18:35
@BrandonPacewic BrandonPacewic requested review from HunterBarclay and a team as code owners July 22, 2024 18:35
@BrandonPacewic BrandonPacewic requested review from PepperLola and azaleacolburn and removed request for a team July 22, 2024 18:35
Copy link
Contributor

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question about a comment, otherwise, LGTM

Copy link
Contributor

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It created new log files each time and correctly logged debug information. Timing looks like it works. I got an error setting the export destination to upload and it sent a message box and logged it.

@HunterBarclay HunterBarclay merged commit 243e49f into dev Jul 24, 2024
13 checks passed
@HunterBarclay HunterBarclay deleted the branp/1735/logging-module-rewrite branch July 24, 2024 07:23
BrandonPacewic added a commit that referenced this pull request Jul 24, 2024
BrandonPacewic added a commit that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants