DEV-164: Added Sails call to init version updates #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug introduced in PR 166 (ArekSredzki#166). The issue is that `/versions/sorted` (changed at line 537 of `data-service.js`) is not a proper blueprint api call and doesn’t initiate web sockets properly to monitor for updates to the version records.
DustinBrett
changed the title
|
Good catch, thanks for the fix! |
m0n99
pushed a commit
to m0n99/electron-release-server
that referenced
this pull request
Mar 20, 2022
…ment-fix DEV-164: Added Sails call to init version updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced in PR 166. The issue is that
/versions/sorted(changed at line 537 ofdata-service.js) is not a proper blueprint api call and doesn’t initiate web sockets properly to monitor for updates to the version records.This was causing the Version Management page to not dynamically update in most cases.