Renewable containers #1809
Merged
Renewable containers #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
guilpier-code
previously requested changes
Dec 11, 2023
src/libs/antares/study/scenario-builder/RenewableTSNumberData.cpp
Outdated
Show resolved
Hide resolved
|
waiting for PR #1813 |
Watermelon AI SummaryAI Summary deactivated by payetvin GitHub PRs
Antares_Simulator is an open repo and Watermelon will serve it for free. |
This was referenced Dec 19, 2023
This PR handles a part of issue #1487 (simplify and clarify cluster lists) : Co-authored-by: Guillaume PIERRE <guillaume.pierre@rte-france.com>
5 tasks
1 task
|
flomnes
approved these changes
Dec 27, 2023
JasonMarechal25
added a commit
that referenced
this pull request
Feb 22, 2024
This PR follows the PR #1809 (about cleaning common cluster list and renewable cluster list) It aims at simplifying thermal cluster lists as much as possible. **Goal** : Having only one list of thermal clusters. This list would be **private** Code would interact with this list through an interface. This interface would contain functions returning **std::views** that would result in filtering thermal clusters using a certain property of clusters : enabled / disabled, must-run or not, a combination of these. **What's done** : - [x] Simplifying the `ClusterList<T>::add()` method - [x] Changing **std::map** `mapping` from class **ThermalClusterList** into a **std::vector** (named `allClusters_`) - [x] Removing **PartThermal::clusters** (often reached by `area.thermal.clusters`) - [x] Removing **PartThermal::mustrunList** (often reached by `area.thermal.mustrunList`) - [x] Removing **PartThermal::list** (often reached by `area.thermal.list.clusters`) **Before starting a review, one should know several things** : - what the old lists of clusters used to contain : - **area.thermal.list.mapping** : all clusters - **area.thermal.mustrunList.clusters** : clusters must-run and enabled - **area.thermal.clusters** : enabled clusters - **area.thermal.list.clusters** : list used to build the optimization problem (clusters enabled and not must-run). Careful with that list : when loading clusters from input, this list contains all clusters. Then it is progressively cleared from disabled and must-run clusters. So its content depends on where we are in the execution. This list is also used from the **GUI**. In that case, it always contains all clusters : it is **not** cleared from specific clusters. - the list **area.thermal.list.clusters** is the only list used in the **GUI**, and in that case, it contains all clusters. - As said previously, all lists of clusters are removed, except **area.thermal.list.mapping**, turned into a private **std::vector** (**area.thermal.list.allClusters_**) containing all clusters, and filtered to access only clusters of interest at any point of the code. - **cluster indices** : any cluster (thermal / renewable) used to have 2 indices : - **index** : it turns out to be an index regarding only enabled and not must-run clusters. So this index never concerns renewable clusters. It was moved down from parent class **Cluster** to class **ThermalCluster**. - **areaWideIndex** : index regarding only enabled clusters. Concerns both thermal and renewable clusters - the 2 lists **area.thermal.mustrunList.clusters** and **area.thermal.list.clusters** are closely related (inter-dependent) to the **renewable** cluster list, due to a common inheritance. So this work deeply impacts the **renewable** cluster lists. --------- Co-authored-by: Vincent Payet <vincent.payet@rte-france.com> Co-authored-by: Jason Maréchal <45510813+JasonMarechal25@users.noreply.github.com> Co-authored-by: Florian OMNES <26088210+flomnes@users.noreply.github.com> Co-authored-by: payetvin <113102157+payetvin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1487