Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leaves - Natalie #40

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

leaves - Natalie #40

wants to merge 5 commits into from

Conversation

NatalieTapias
Copy link

@NatalieTapias NatalieTapias commented Dec 10, 2019 •
edited
Loading

Linked List Comprehension Questions

Question Response
1. What advantages does a LinkedList have over an Array? A linked list provides an opportunity to add data or remove data at the front of a dataset with constant time complexity. You also have the advantage of using non-contiguous locations in memory, and are not constrained to adjacent locations in memory as an array will.
2. When is an Array more advantageous? An array is more advantageous when you want to perform a quick lookup based on when you have the index. Finding a value in a sorted array is also relatively faster than finding a value stored in a linked list.

CheezItMan
CheezItMan reviewed Dec 18, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You definitely have a feel for linked lists, but you have a few bugs here. Take a look at my comments and let me know if you have questions.

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def add_first(data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(1)
# Space complexity - O(1)
def get_first
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n) where N is the index
# Space complexity - ? O(1)
def get_at_index(index)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about if the index is greater than the length of the list?

lib/linked_list.rb
def get_last
current = head
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if head is nil?

Suggested change
current = head
return nil if head.nil?
current = head

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n) where n is the number of elements in the list
# Space complexity - O(1)
def add_last(data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lib/linked_list.rb
# Time complexity - ?
# Space complexity - ?
# Time complexity - ? O(n) where N is the number of elements in the linked list
# Space complexity - O(1)
def length
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NatalieTapias @CheezItMan