Leaves - Cloudy #49
Open
Leaves - Cloudy #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing .join. super lame.
Grocery StoreWhat We're Looking For
|
dHelmgren
reviewed
Sep 3, 2019
| describe "Order.all" do | ||
| it "Returns an array of all orders" do | ||
| # TODO: Your test code here! | ||
| end | ||
|
|
||
| it "Returns accurate information about the first order" do |
There was a problem hiding this comment.
This test fails, see comment in orders.rb
| # Check that all data was loaded as expected | ||
| expect(order.id).must_equal id | ||
| expect(order.products).must_equal products | ||
| expect(order.customer).must_be_kind_of Customer | ||
| expect(order.customer.id).must_equal customer_id | ||
| expect(order.fulfillment_status).must_equal fulfillment_status | ||
| end | ||
|
|
||
| it "Returns accurate information about the last order" do | ||
| # TODO: Your test code here! |
There was a problem hiding this comment.
It's a good idea to scan your code for TODO:s before submitting.
| } | ||
| customer_id = order[2] | ||
| fulfillment_status = order[3] | ||
| order = Order.new(order_id, products, customer_id, fulfillment_status) |
There was a problem hiding this comment.
As written, this code will always fail. initialize is expecting a :symbol for fulfillment_status (see lines 13-15). Your test caught this, but it looks like it didn't get fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grocery Store
Congratulations! You're submitting your assignment.
Comprehension Questions
raise ArgumentError?.all&.findmethods class methods? Why not instance methods?OrderandCustomer. Is this relation one-to-one, one-to-many, or something else? How does that compare to the Solar System project?OrderandCustomertracked in the CSV file? How is it tracked in your program? Why might these be different?