Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - C. Gutierrez #47

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

CEsGutierrez
Copy link

Grocery Store

Congratulations! You're submitting your assignment.

Comprehension Questions

Question Response
What is accomplished with raise ArgumentError? This is a way to flag input that is not desirable.
Why do you think we made the .all & .find methods class methods? Why not instance methods? These methods will be able to iterate across any instance of the class.
Think about the relation between Order and Customer. Is this relation one-to-one, one-to-many, or something else? How does that compare to the Solar System project? One to many with one customer able to place many orders. It is similar to Solar System in how one solar system can have many planets, however, more complex because there's more than one customer worth of data whereas solar system just had a single solar system instance.
How is the relation between Order and Customer tracked in the CSV file? How is it tracked in your program? Why might these be different? It is tracked with the customer being an instance variable in orders which is an instance of a customer.
Did the presence of automated tests change the way you thought about the problem? How? I was able to read the tests better to determine the type of output that was desired as well as see acceptable input scenarios.

@jmaddox19
Copy link

jmaddox19 commented Sep 5, 2019

Grocery Store

What We're Looking For

Feature Feedback
Baseline
Answered comprehension questions X
Used Git Regularly I would recommend making your commit messages a bit more descriptive. Ideally, the reader would understand at a high-level what you did in each commit without even needing to look at your code. (assuming they understand the assignment/context pretty well).
Wave 1
All provided tests pass X
Using the appropriate attr_ for instance variables X
Wave 2
All stubbed tests are implemented fully and pass X
Used CSV library only in .all (not in .find) X
Appropriately parses the product data from CSV file in Order.all X
Order.all calls Customer.find to set up the composition relation You used Customer.all and basically rewrote Customer.find. Could've called Customer.find for "dry-er" code.
Additional Notes Great job overall! One callout: your code doesn't run in its current state because it's missing an "end". Just from you commenting out that last method and commenting out a bit extra. That said, it's definitely a good practice to run "rake" one last time before submitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants