Branches - Macaria #31
Conversation
… file to include corresponding test
|
|
||
| # Build Customer class, instantiate readers for instance variables. | ||
| class Customer | ||
| attr_reader :id, :all_customers, :email, :address |
There was a problem hiding this comment.
While I personally would make these all attr_readers in my own code the spec did say to make everything but id read and write.
It's not a big deal though, and I'm not sure if we maybe want to update the assignment.
| def self.all | ||
| all_customers = [] | ||
| array_array_customers = CSV.read("data/customers.csv") | ||
| array_array_customers.each do |customer| |
There was a problem hiding this comment.
array_array_customers is kind of an odd name, I would probably name it something like customer_rows instead.
Also, since you only reference it once you can simply inline the CSV.read and not bother naming it:
| array_array_customers.each do |customer| | |
| CSV.read("data/customers.csv").each do |customer| |
| # Build Order Class and instantiate instance variables include readers for all attributes | ||
| class Order | ||
| attr_reader :id, :products, :customer, :fulfillment_status | ||
| VALID_STATUSES = [:pending, :paid, :processing, :shipped, :complete] |
|
|
||
| # Validate that input was among the included possible statuses. Raise error, otherwise. | ||
| if !VALID_STATUSES.include?(fulfillment_status) | ||
| raise ArgumentError.new("Invalid Status") |
There was a problem hiding this comment.
It's helpful for debugging to say what status was invalid.
| raise ArgumentError.new("Invalid Status") | |
| raise ArgumentError.new("Invalid Status: #{fulfillment_status}") |
| @products.each do |product, price| | ||
| if @products.empty? | ||
| total_amount = 0.0 | ||
| else total_amount += price.to_f |
There was a problem hiding this comment.
The body of your if was on its own line, but not the else (which makes it easy to overlook).
| else total_amount += price.to_f | |
| else | |
| total_amount += price.to_f |
| end | ||
| end | ||
| total_amount = (total_amount * 1.075) | ||
| return (sprintf("%.2f", total_amount).to_f) |
There was a problem hiding this comment.
You can use round for this:
| return (sprintf("%.2f", total_amount).to_f) | |
| return total_amount.round(2) |
|
Well done! Aside from a few small things the only note I've got is that you could have saved yourself a little work by using some Enumerable methods. Good job though. 😀 |
Grocery Store
Congratulations! You're submitting your assignment.
Comprehension Questions
raise ArgumentError?.all&.findmethods class methods? Why not instance methods?OrderandCustomer. Is this relation one-to-one, one-to-many, or something else? How does that compare to the Solar System project?OrderandCustomertracked in the CSV file? How is it tracked in your program? Why might these be different?