-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autopackaging and publish the wheels #1581
Autopackaging and publish the wheels #1581
Conversation
BTW, to avoid some issues I created that workflow to check the version |
That's all from my side! I hope all this helps you out! Feel free to reach me out in any case. Meanwhile I will move to other projects I really need to attend |
Thanks, I'll look through this more carefully shortly. The version check is failing with:
Do you know what's going on there? Also, the DCO (Developer Certificate of Origin) check has failed, since the ASWF requires signed commits. Could you kindly resubmit with "commit -s"? This applies to all commits, so it may be easier to squash all your commit history down into a single commit created with -s. Apologies for this hassle. |
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
…014) Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
Signed-off-by: Jose Luis Cercos-Pita <jlcercos@gmail.com>
c3c3f5f
to
70089a6
Compare
The commits are signed now
The version checker is just checking that there is no a tag with the same version than the one you are trying to merge on main. Of course, the version checking and the packages publishing shall reflect the way you guys work and create releases. Along this line, the most popular way to go is having a dev branch where the commits are landing (first commit after each release is always increasing the version), and a main branch where just releases are merged. Then the CI/CD is taking care of creating a tag & release, as well as crafting & publishing the Python wheels. The merits of that approach are:
Anyway, it seems to me that you are more used to develop on main, and then have separate branches to cherry-pick the commits for the next release. I suppose you create your tags and releases manually. If I am right, you can just simply get rid of I strongly recommend you to give it a thought. Anyway, it is something you have to decide and do yourselves. |
Note: Please, do not do this when you know someone is working on that Hi @sanguinariojoe .. I apologize if I did something wrong. But I don't quite understand what I did wrong. Was there a ban on making changes as you worked on this ? |
No problem at all.
AFAIK you guys discussed about the Python package, so I suppose you know I
am landing with significant changes.
Thus, any commit will be a conflict.
But as i said, no prob!
…On Thu, 19 Oct 2023, 19:20 Barnaby Robson, ***@***.***> wrote:
Note: Please, do not do this
<4de528d>
when you know someone is working on that
Hi @sanguinariojoe </~https://github.com/sanguinariojoe> .. I apologize if
I did something wrong. But I don't quite understand what I did wrong.
Was there a ban on making changes as you worked on this ?
—
Reply to this email directly, view it on GitHub
<#1581 (comment)>,
or unsubscribe
</~https://github.com/notifications/unsubscribe-auth/AAMXKKAEU2X2RUP7IG2CZQ3YAFOPRAVCNFSM6AAAAAA6CBTFN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZRGQYTCNRQHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Do you know when is the release date? |
Hey guys! I am archiving my repo (/~https://github.com/sanguinariojoe/pip-openexr) since I definitely do not want to address problems there |
@sanguinariojoe @cary-ilm It looks like we need to make a decision on
to move ahead? The proposal sounds like the right idea to me. If it succeeds then we are ready to land? |
If you guys confirm me you wanna go that way (triggering the pipy auto-publishing when releases are created), then I can correct the CI/CD in no time so you can merge. After that you'll be set. @cary-ilm , please let me know |
Apologies for the delay, but I haven't had time to look this over thoroughly enough yet, but I will get to it in the next few days. |
What is the status on this? |
I'll have time to work on this during the first week of December, I hope to resolve it then and make an official release. |
name: python-wheels-MacOS_universal2 | ||
path: dist/ | ||
|
||
- name: Publish package to TestPyPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually TestPyPI?
with: | ||
name: "Python wheels" | ||
path: ./wheelhouse/*.whl | ||
password: ${{ secrets.OPENEXR_PYPI_API }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could use the new trusted publisher system instead of an API key: https://blog.pypi.org/posts/2023-04-20-introducing-trusted-publishers/#using-trusted-publishing-with-github-actions
classifiers = [ | ||
"Programming Language :: Python :: 3", | ||
"License :: OSI Approved :: BSD License", | ||
"Operating System :: OS Independent", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is true – the wheels are OS dependent?
Is there any update on this? I am using Python 3.5m which is bundled with Blender 2.79a in in a docker that has base Ubuntu 18.04 inside native Ubuntu 22.04. This is the only package that doesn't get installed:
|
I'm getting to this now after a lengthy delay, I hope to have an update shortly. |
@cary-ilm thanks a lot for looking into this |
@cary-ilm just a note that I fixed the formatting for Python 3.5m and still same error:
in
and
|
@monajalal, I'm still working my way through a fresh installation of the OpenEXR bindings and the various related issues, but one thing to note is that the bindings from sanguinariojoe/pip-openexr have been folded into AcademySoftwareFoundation/OpenEXR and that original repo archived so any new fixes will go into the new repo. If I'm reading your logs correctly, it looks like you're building the pip-openexr project. Would it be possible for you to build the new version of the bindings? If you're committed to the old repo, I'm not familiar enough with it to offer much guidance. |
@cary-ilm any chance you could guide me how to build the python package for OpenEXR using /~https://github.com/AcademySoftwareFoundation/openexr ? |
@monajalal, this may change so it's yet to make it into the documentation, but do this: % cmake -DOPENEXR_BUILD_PYTHON=ON |
Thank you. Could you please guide how to force it to use the Python here instead of Python 3.6?
I see this file is looking for it
|
I might have gotten it workig please let me know if it makes any sense -- I am confused because it also said
I change this file
Unfortunately, still
|
Following up on this, this PR has been reformulated as #1629, which replaces the |
BEFORE MERGING THIS:
@cary-ilm you should go to https://pypi.org/manage/account/token/?selected_project=OpenEXR and create a token with the name
OPENEXR_PYPI_API
and the scopeProject: openexr
. Take good note of it, because it will be shown just once. Then on GitHUB you should go to Settings/Secrets and variables/Actions, click on new repository secret and create it with the very same name,OPENEXR_PYPI_API
, and the token you copied from pypi.@everyone, make sure you have the release ready. More info below.
RATIONALE:
On every single pull request and push (which is affecting the paths you set) the wheels for the standard/native archs will be built and test. Even an emulated one. That job would take ~15 minutes
Only the pushes on main branch will trigger the building for all the archs and autopublishing on pypi. That task would take about 2 hours.
Watch out! When you publish a file on pypi it cannot be overwritten. NEVER AND EVER. Thus you should never dev on main branch. Of course you can change this behavior. just editing the workflow. Just bear this on mind, a published file CANNOT be overwritten.
Note: The pipeline will fail until merged because of this
Note: Please, do not do this when you know someone is working on that