[BREAKING CHANGE] feat: support sqlite-vec (#216) #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| #[cfg(not(feature = "sqlite-vec"))] |
There was a problem hiding this comment.
missing ollama flag
return764
force-pushed
the
support-sqlite-vec
branch
from
c3ecb36 to
2e517e4
Compare
|
Is there any update on this PR? |
|
Tested the PR and looks good. You do need to update the vector dimension to 1536 for openai instead. |
prabirshrestha
changed the title
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support sqlite-vec, I basically referenced the code of sqlite-vss, except for using the format supported by sqlite-vec for table creation, i'm not sure it absolutely right, but i have run in my own project.