Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for integration into CICERO advisor #9

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

aphedges
Copy link
Contributor

This PR contains changes needed for using chiron-utils in the CICERO advisor. I made and tested these commits during my integration work.

As an oversight on my part, the advisor would only declare its
suggestion type during movement phases, but advice should be available
during any phase. Factoring it out into a separate method allows us to
be more flexible about when we call it.
This implements the protocol from CICERO. I guess I forgot to include
this when I added support for suggesting complete orders.
This will limit possible problems if custom `__post_init__()` logic is
added to the subclass.
@aphedges aphedges added the enhancement New feature or request label Oct 14, 2024
@aphedges aphedges self-assigned this Oct 14, 2024
@aphedges aphedges merged commit 3ec3b71 into main Oct 14, 2024
1 check passed
@aphedges aphedges deleted the cicero-advisor-integration branch October 14, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant