Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark script for saving benchmark result #117

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

lsy323
Copy link
Contributor

@lsy323 lsy323 commented Jul 19, 2024

if args.additional_metadata_metrics_to_save is None, json.loads would fail. args.additional_metadata_metrics_to_save is None by default. Adding a check to avoid the failure.

Test:
Using the benchmark example script in README

python JetStream/benchmarks/benchmark_serving.py   \
--tokenizer ~/maxtext/assets/tokenizer.llama2  \
--warmup-mode full   \
--save-result   \
--save-request-outputs   \
--request-outputs-file-path outputs.json   \
--num-prompts 1000   \
--max-output-length 1024   \
--dataset openorca

@lsy323 lsy323 requested a review from vipannalla as a code owner July 19, 2024 05:03
@lsy323 lsy323 changed the title Fix benchmark script to save benchmark result Fix benchmark script for saving benchmark result Jul 19, 2024
Copy link
Contributor

@FanhaiLu1 FanhaiLu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@JoeZijunZhou JoeZijunZhou merged commit 6ec67e4 into AI-Hypercomputer:main Jul 19, 2024
3 checks passed
@lsy323 lsy323 deleted the lsiyuan/fix-script branch July 22, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants