Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lured pokemon webhook #3302

Closed
wants to merge 2 commits into from
Closed

Lured pokemon webhook #3302

wants to merge 2 commits into from

Conversation

hhu94
Copy link
Contributor

@hhu94 hhu94 commented Aug 3, 2016

Description

Implemented a webhook for lured pokemon that is parallel to the normal pokemon webhook.

Motivation and Context

This allows third party apps like PokeAlarm to notify when a lured pokemon appears.
The new webhook works directly with PokeAlarm's latest version without the need of any changes from their part because it follows the message follows the same basic structure as that of normal pokemon's.

One thing to keep in mind is the 'unknown2' field in the FortLureInfo proto. This is actually a 'encounter_id' field in the newer pgoapi version. So the 'unknown2' in this patch will have to be changed to 'encounter_id' when we eventually update our pgoapi package as per #3106

How Has This Been Tested?

Lured pokemon are displayed without a problem on PokeAlarm's latest version.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@AHAAAAAAA
Copy link
Owner

Putting this on hold until pgoapi purge goes through, so we can update unknown2 prior to merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants