Omit previous transaction for taproot inputs #579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We include the whole previous transaction in `tx_add_input` to protect against malleability attacks that affect segwit v0. Since lightning messages are limited to 65kB, this has an annoying consequence: if the input you're trying to spend comes from a large transaction, you cannot use it with the `interactive-tx` protocol. This is happening in practice with coinjoins and payouts from mining pools. Since segwit v1+ is not affected by this malleability issue, we can relax that requirement and only send the corresponding `txout`.
sstone
added a commit
that referenced
this pull request
Jan 22, 2024
They use taproot v1, providing the tx output and not the entire tx is safe (see #579). Here we add the swap-in input output and txout to the swap-in TLV, so this change does not interface with proposed changes to the LN spec.
sstone
added a commit
that referenced
this pull request
Jan 23, 2024
They use taproot v1, providing the tx output and not the entire tx is safe (see #579). Here we add the swap-in input output and txout to the swap-in TLV, so this change does not interface with proposed changes to the LN spec.
sstone
added a commit
that referenced
this pull request
Jan 24, 2024
They use taproot v1, providing the tx output and not the entire tx is safe (see #579). Here we add the swap-in input output and txout to the swap-in TLV, so this change does not interface with proposed changes to the LN spec.
sstone
added a commit
that referenced
this pull request
Jan 24, 2024
They use taproot v1, providing the tx output and not the entire tx is safe (see #579). Here we add the swap-in input output and txout to the swap-in TLV, so this change does not interface with proposed changes to the LN spec.
sstone
added a commit
that referenced
this pull request
Jan 29, 2024
They use taproot v1, providing the tx output and not the entire tx is safe (see #579). Here we add the swap-in input output and txout to the swap-in TLV, so this change does not interface with proposed changes to the LN spec.
|
We unfortunately cannot safely omit the |
sstone
added a commit
that referenced
this pull request
Feb 6, 2024
They use taproot v1, providing the tx output and not the entire tx is safe (see #579). Here we add the swap-in input output and txout to the swap-in TLV, so this change does not interface with proposed changes to the LN spec.
sstone
added a commit
that referenced
this pull request
Feb 8, 2024
They use taproot v1, providing the tx output and not the entire tx is safe (see #579). Here we add the swap-in input output and txout to the swap-in TLV, so this change does not interface with proposed changes to the LN spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We include the whole previous transaction in
tx_add_inputto protect against malleability attacks that affect segwit v0. Since lightning messages are limited to 65kB, this has an annoying consequence: if the input you're trying to spend comes from a large transaction, you cannot use it with theinteractive-txprotocol.This is happening in practice with coinjoins and payouts from mining pools. Since segwit v1+ is not affected by this malleability issue, we can relax that requirement and only send the corresponding
txout.This is proposed to the spec in niftynei/lightning-rfc#18