Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests to changed error handling of ABCI methods #41

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

bermuell
Copy link
Collaborator

Description

Error handling changed in this fork of Cosmos SDK for ABCI methods PrepareProposal and ExtendVote see PR#39
This PR adapts the existing tests to these changes.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to bor
    • In case link the PR here:
  • This PR requires changes to heimdall-v2
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy/mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@bermuell bermuell force-pushed the bermuell/fix-tests-abci-methods branch from d57dd31 to accf481 Compare January 21, 2025 15:24
@bermuell bermuell marked this pull request as ready for review January 21, 2025 15:31
@bermuell bermuell requested a review from avalkov January 21, 2025 15:33
@bermuell bermuell force-pushed the bermuell/fix-tests-abci-methods branch from accf481 to d65af1a Compare January 22, 2025 09:16
@bermuell bermuell changed the title Adapt tests to changed error handling of ABCI PrepareProposal Adapt tests to changed error handling of ABCI methods Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants