Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework third chapter #41

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Rework third chapter #41

wants to merge 11 commits into from

Conversation

0xAX
Copy link
Owner

@0xAX 0xAX commented Jan 7, 2025

Description

This PR provides rework of the third chapter.

0xAX added 9 commits January 6, 2025 15:36
@0xAX
asm-3: initial update
b6a26e2 
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
@0xAX
finish first section
543c6e6 
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
@0xAX
asm-3: finish rework of the first chapter
7efa28f 
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
@0xAX
fix the link
fffb387 
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
@0xAX
asm-3: big rework
5f99bd3 
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
@0xAX
asm-3: add table from ABI
12a835e 
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
@0xAX
asm-3: stub for security considerations
f310df1 
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
@0xAX
asm-3: finish content
e302ee5 
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
@0xAX
Finish initial rework of asm-3
5202596 
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
@0xAX 0xAX requested a review from klaudiagrz as a code owner January 7, 2025 13:06
klaudiagrz
klaudiagrz reviewed Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@klaudiagrz klaudiagrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of all files except the main post

stack/README.md Outdated Show resolved Hide resolved
stack/README.md Outdated Show resolved Hide resolved
content/assets/asm-3-stack-of__double-1.svg Outdated Show resolved Hide resolved
content/assets/asm-3-stack-of__double-2.svg Outdated Show resolved Hide resolved
stack/stack.asm Outdated Show resolved Hide resolved
stack/stack.asm Outdated Show resolved Hide resolved
stack/stack.asm Outdated Show resolved Hide resolved
stack/stack.asm Outdated Show resolved Hide resolved
stack/stack.asm Outdated Show resolved Hide resolved
stack/stack.asm Outdated Show resolved Hide resolved
@klaudiagrz
Copy link
Collaborator

Please adjust the descriptions also in the code sample of the third post.

klaudiagrz
klaudiagrz reviewed Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@klaudiagrz klaudiagrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the intro section

content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
@0xAX
asm-3: adjust after first round of comments
91723b9 
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
klaudiagrz
klaudiagrz reviewed Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@klaudiagrz klaudiagrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftovers from the previous review

stack/stack.asm Outdated Show resolved Hide resolved
stack/stack.asm Outdated Show resolved Hide resolved
stack/stack.asm Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
klaudiagrz
klaudiagrz reviewed Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@klaudiagrz klaudiagrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the "Stack operations" section

content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
content/asm_3.md Outdated Show resolved Hide resolved
@0xAX
asm-3: another round of review
b89086b 
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaudiagrz klaudiagrz klaudiagrz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xAX @klaudiagrz