Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve type output for narrowed interfaces (intersect members of unions instead) #370

Merged
merged 3 commits into from
Aug 18, 2024
Merged

fix: Improve type output for narrowed interfaces (intersect members of unions instead) #370

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
744837c
Improve type output on getPossibleTypeSelectionRec union
kitten Aug 18, 2024
d41eb3c
Add typename narrowing with improved output
kitten Aug 18, 2024
9bab4f9
Add changeset
kitten Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Improve type output on getPossibleTypeSelectionRec union
  • Loading branch information
@kitten
kitten committed Aug 18, 2024
commit 744837c6ea9697935dacc5f1556be3f8ab99e058
4 changes: 3 additions & 1 deletion src/selection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,9 @@ type getPossibleTypeSelectionRec<
>
: SelectionAcc
>
: obj<SelectionAcc['fields']> & SelectionAcc['rest'];
: SelectionAcc['rest'] extends infer T
? obj<SelectionAcc['fields'] & T>
: never;

type getOperationSelectionType<
Definition,
Expand Down