-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model/boxes: Allow users to post stream messages without a topic. #757
Conversation
e13087b
to
3e67354
Compare
3e67354
to
59439d3
Compare
e5c60cb
to
5ada285
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaustubh-nair This looks good functionally 👍 I left two minor points inline; otherwise my only thought is whether we should add a test for the UI, since we dropped them in the case where the functionality was elsewhere?
5ada285
to
0de5f0a
Compare
bc6bfb4
to
8a5347a
Compare
@neiljp Thanks for the review! This is ready |
@kaustubh-nair Your first commit claims to have added a test, but there is only a test in the second commit. Did you mean to have a simple test in that first commit and then extend it in the second? |
This puts stream related function calls in the same block, thus making changes to content/topic becomes easy.
This follows the convention used by other Zulip clients to automatically post a message without a topic, or a topic with only whitespaces, to a topic named '(no topic)'. Test added. Fixes zulip#754.
8a5347a
to
123aabb
Compare
@neiljp That's what I had planned before, but the logic in the first commit is too simple to require a test, so I thought I'd just add one for topic matching in the second one. It would just involve checking if the model methods are called with mocked parameters. |
@kaustubh-nair Thanks - I just wanted clarification on the test before merging, though I also combined some test lines in the mocking before merging manually. In any case, another good merge! 🎉 |
This follows the convention used by other Zulip clients to
automatically post a message without a topic, or a topic with only
whitespaces, to a topic named '(no topic)'.
Tests amended.
Fixes #754.