Do not mark as read on search narrows #723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, messages are mark read even if the user is in any search narrow which affects the message reading experience. This doesn't mark messages as read on any search narrow much like the web app. Test added and amended. Fixes zulip#624.
zulipbot
added
size: S
sumanthvrao
approved these changes
Jul 18, 2020
|
@preetmishra Thanks for working on this, it works well, and shows a clear path to implementing the 'explore' mode and possibly other non-reading modes (all messages?). I just manually merged this with two small commit text adjustments 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't mark messages as read on any search narrow like the web app.
Fixes #624.