better error message for #95

zordius · Jul 23, 2014 · 4f036af · 4f036af
1 parent a4a680f
commit 4f036af
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/src/lightncandy.php b/src/lightncandy.php
@@ -1404,7 +1404,7 @@ protected static function scanFeatures($token, &$context) {
         }
 
         if (!isset($vars[0])) {
-            return static::noNamedArguments($token, $context, true);
+            return static::noNamedArguments($token, $context, true, ', you should use it after a custom helper.');
         }
 
         if ($vars[0] !== 'else') {
@@ -1445,9 +1445,9 @@ protected static function scanFeatures($token, &$context) {
      * @param array $context current compile context
      * @param boolean $named is named arguments
      */
-    public static function noNamedArguments($token, &$context, $named) {
+    public static function noNamedArguments($token, &$context, $named, $suggest = '!') {
         if ($named) {
-            $context['error'][] = 'Do not support name=value in ' . static::tokenString($token) . '!';
+            $context['error'][] = 'Do not support name=value in ' . static::tokenString($token) . $suggest;
         }
     }
 
@@ -1542,7 +1542,7 @@ public static function compileToken(&$token, &$context) {
             return $ret;
         }
 
-        static::noNamedArguments($token, $context, $named);
+        static::noNamedArguments($token, $context, $named, ', maybe you missing the custom helper?');
 
         return static::compileVariable($context, $vars, $raw);
     }
@@ -1600,7 +1600,7 @@ protected static function compileSection(&$token, &$context, &$vars, $named) {
             if ($r) {
                 return $r;
             }
-            static::noNamedArguments($token, $context, $named);
+            static::noNamedArguments($token, $context, $named, ', maybe you missing the block custom helper?');
             return static::compileBlockBegin($context, $vars);
         }
     }

diff --git a/tests/errorTest.php b/tests/errorTest.php
@@ -280,7 +280,17 @@ public function errorProvider()
              Array(
                  'template' => '{{a=b}}',
                  'options' => Array('flags' => LightnCandy::FLAG_NAMEDARG),
-                 'expected' => 'Do not support name=value in {{a=b}}!',
+                 'expected' => 'Do not support name=value in {{a=b}}, you should use it after a custom helper.',
+             ),
+             Array(
+                 'template' => '{{test a=b}}',
+                 'options' => Array('flags' => LightnCandy::FLAG_NAMEDARG),
+                 'expected' => 'Do not support name=value in {{test a=b}}, maybe you missing the custom helper?',
+             ),
+             Array(
+                 'template' => '{{#test a=b}}YA~{{/test}}',
+                 'options' => Array('flags' => LightnCandy::FLAG_NAMEDARG),
+                 'expected' => 'Do not support name=value in {{#test a=b}}, maybe you missing the block custom helper?',
              ),
              Array(
                  'template' => '{{#foo}}1{{^}}2{{/foo}}',